ci: update GitHub Actions to latest versions#78
Merged
Merged
Conversation
Bump actions/checkout v2->v4, actions/setup-node v1->v4, and actions/cache v1->v4. Add persist-credentials: false to checkouts and modernize cache key config.
react-select@^3.2.0 requires react >=16.8 but the project pins react@16.6.3, which npm 7+ treats as a hard ERESOLVE error and fails npm ci. Enable legacy-peer-deps to restore the prior resolution behavior.
The lockfile had been regenerated at lockfileVersion 2, under which npm 7+ strictly enforces peer deps and fails npm ci because react-select@^3.2.0 wants react >=16.8 while the project pins react@16.6.3. Regenerate as lockfileVersion 1 (matching the other nerdpacks) so npm ci resolves without the conflict. Removes the .npmrc legacy-peer-deps workaround.
react@16.6.3 failed react-select@^3.2.0's peer requirement (react >=16.8), causing npm ci to fail with ERESOLVE under npm 7+. Bump to ^16.14.0, the highest react 16 release, which satisfies all peers (react-select, semantic-ui-react, react-virtualized). react 17 is not viable here because react-virtualized@9.22.2 caps react at 16. Regenerated lockfile resolves cleanly without legacy-peer-deps.
Contributor
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump actions/checkout v2->v4, actions/setup-node v1->v4, and actions/cache v1->v4. Add persist-credentials: false to checkouts and modernize cache key config.